lainns-mirror/noctalia-shell
1
0
Fork 0
mirror of https://github.com/noctalia-dev/noctalia-shell.git synced 2026-05-11 17:08:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(brightness): handle DRM_connector format in ddcutil output

Browse Source 
Fixes #1427

The regex for parsing DRM connector from ddcutil output only matched
"DRM connector:" (with space), but newer versions of ddcutil output
"DRM_connector:" (with underscore).

This caused the connector field to be empty for all DDC monitors,
making it impossible to distinguish between multiple identical
monitors (e.g., two "Mi Monitor" displays on DP-2 and DP-3).

The fix uses a character class [_ ] to match both formats.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
WojciechSulocki-Gif
2026-01-17 22:17:50 +01:00
parent e6d92f502d
commit e4d321e1af
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Services/Hardware/BrightnessService.qml
+1 -1
View File
@@ -104,7 +104,7 @@ Singleton {
var ddcModelMatch = d.match(/(This monitor does not support DDC\/CI|Invalid display)/);
var modelMatch = d.match(/Model:\s*(.*)/);
var busMatch = d.match(/I2C bus:[ ]*\/dev\/i2c-([0-9]+)/);
var connectorMatch = d.match(/DRM connector:\s*card\d+-(.+)/);
var connectorMatch = d.match(/DRM[_ ]connector:\s*card\d+-(.+)/);
var ddcModel = ddcModelMatch ? ddcModelMatch.length > 0 : false;
var model = modelMatch ? modelMatch[1] : "Unknown";
var bus = busMatch ? busMatch[1] : "Unknown";