lainns-mirror/noctalia-shell
1
0
Fork 0
mirror of https://github.com/noctalia-dev/noctalia-shell.git synced 2026-05-11 17:08:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Settings: removed isSettings everywhere as we can simply check if defaultValue is provided.

Browse Source
This commit is contained in:
Lemmy
2026-01-05 18:41:22 -05:00
parent 0f8219cfb2
commit ffa8cc58a1
37 changed files with 30 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Widgets/NComboBox.qml
+4 -5
View File
@@ -15,8 +15,7 @@ RowLayout {
property var model
property string currentKey: ""
property string placeholder: ""
property bool isSettings: false
property var defaultValue: ""
property var defaultValue: undefined
property string settingsPath: ""
readonly property real preferredHeight: Math.round(Style.baseWidgetSize * 1.1)
@@ -29,10 +28,10 @@ RowLayout {
opacity: enabled ? 1.0 : 0.6
// Less strict comparison with != (instead of !==) so it can properly compare int vs string (ex for FPS: 30 and "30")
readonly property bool isValueChanged: isSettings && (currentKey != defaultValue)
readonly property bool isValueChanged: (defaultValue !== undefined) && (currentKey != defaultValue)
readonly property string indicatorTooltip: {
if (!isSettings)
if (defaultValue === undefined)
return "";
var displayValue = "";
if (defaultValue === "") {
@@ -128,7 +127,7 @@ RowLayout {
NLabel {
label: root.label
description: root.description
showIndicator: root.isSettings && root.isValueChanged
showIndicator: root.isValueChanged
indicatorTooltip: root.indicatorTooltip
}